[red-knot] support typing.Union in type annotations
#14499
Conversation
|
Is it possible to auto tag my PR as redknot by using a specific word in the description or title? |
typing.Union in type annotations
|
crates/red_knot_python_semantic/resources/mdtest/annotations/union.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/annotations/union.md
Outdated
Show resolved
Hide resolved
…nion.md Co-authored-by: Carl Meyer <[email protected]>
…nion.md Co-authored-by: Carl Meyer <[email protected]>
No, unfortunately we don't have anything like that set up. It would be nice to have! |
crates/red_knot_python_semantic/resources/mdtest/annotations/union.md
Outdated
Show resolved
Hide resolved
|
Noticed a couple more small changes on reviewing the latest, pushed those too... |
| KnownInstanceType::Union => match parameters { | ||
| ast::Expr::Tuple(t) => UnionType::from_elements( | ||
| self.db, | ||
| t.iter().map(|elt| self.infer_type_expression(elt)), | ||
| ), | ||
| _ => self.infer_type_expression(parameters), | ||
| }, |
There was a problem hiding this comment.
This is extremely subtle, but with this change, we now fail to infer a type for the ast::Expr::Tuple expression itself. We only infer types for the sub-expressions via self.infer_type_expression(elt), but we don't store a type for the overall ast::Expr::Tuple (only for the whole slice expression).
In other words, when we have something like Union[str, int], we do infer types for the whole slice expression Union[str, int]. We also infer types for int and str, but we do not infer/store a type for the int, str tuple expression.
Unfortunately, the test that would have caught this is currently deactivated (see #14391), but I hope we can re-activate it soon.
I'll open a PR with a fix (Edit: #14510).
) ## Summary Fixes a panic related to sub-expressions of `typing.Union` where we fail to store a type for the `int, str` tuple-expression in code like this: ``` x: Union[int, str] = 1 ``` relates to [my comment](#14499 (comment)) on #14499. ## Test Plan New corpus test
Fix #14498
Summary
This PR adds
typing.UnionsupportTest Plan
I created new tests in mdtest.