Fixed clippy lint warnings

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "xorshift"
-version = "0.1.2"
+version = "0.1.3"
 authors = ["Alexander Stocko <[email protected]>"]
 license = "CC0-1.0"
 readme = "README.md"

README.md

@@ -49,6 +49,10 @@ fn main() {
  // Generate 20 random u32s
  let vals = rng.gen_iter::<u32>().take(20).collect::<Vec<u32>>();
  println!("Xorshift1024* random u32: {:?}", vals);
+
+ // Generate 50 random u64s
+ let vals = rng.gen_iter::<u64>().take(50).collect::<Vec<u64>>();
+ println!("Xorshift1024* random u64: {:?}", vals);
 }
 
 ```

src/lib.rs

@@ -47,6 +47,10 @@
 //! // Generate 20 random u32s
 //! let vals = rng.gen_iter::<u32>().take(20).collect::<Vec<u32>>();
 //! println!("Xorshift1024* random u32: {:?}", vals);
+//!
+//! // Generate 50 random u64s
+//! let vals = rng.gen_iter::<u64>().take(50).collect::<Vec<u64>>();
+//! println!("Xorshift1024* random u64: {:?}", vals);
 //! }
 //!
 //! ```

src/splitmix64.rs

@@ -6,7 +6,7 @@
 //
 // See <LICENSE or http:https://creativecommons.org/publicdomain/zero/1.0/>
 
-//! The SplitMix64 random number generator.
+//! The `SplitMix64` random number generator.
 
 use std::num::Wrapping as w;
 use rand::{Rand, Rng, SeedableRng};
@@ -16,10 +16,10 @@ use rand::{Rand, Rng, SeedableRng};
 /// # Description
 /// Quoted from [1].
 ///
-/// This is a fixed-increment version of Java 8's SplittableRandom
+/// This is a fixed-increment version of Java 8's `SplittableRandom`
 /// generator [2] and [3].
 ///
-/// It is a very fast generator passing BigCrush, and it can be useful if
+/// It is a very fast generator passing `BigCrush`, and it can be useful if
 /// for some reason you absolutely want 64 bits of state; otherwise, we
 /// rather suggest to use a xoroshiro128+ (for moderately parallel
 /// computations) or xorshift1024* (for massively parallel computations)

src/xoroshiro128.rs

@@ -9,7 +9,9 @@
 //! The Xoroshiro128+ random number generator.
 
 use std::num::Wrapping as w;
+
 use rand::{Rand, Rng, SeedableRng};
+
 use RngJump;
 
 const STATE_SIZE: usize = 2;
@@ -20,11 +22,11 @@ const STATE_SIZE: usize = 2;
 /// Quoted from [1].
 ///
 /// This is the successor to xorshift128+. It is the fastest full-period
-/// generator passing BigCrush without systematic failures, but due to the
+/// generator passing `BigCrush` without systematic failures, but due to the
 /// relatively short period it is acceptable only for applications with a
 /// mild amount of parallelism; otherwise, use a xorshift1024* generator.
 ///
-/// Beside passing BigCrush, this generator passes the PractRand test suite
+/// Beside passing `BigCrush`, this generator passes the `PractRand` test suite
 /// up to (and included) 16TB, with the exception of binary rank tests,
 /// which fail due to the lowest bit being an LFSR; all other bits pass all
 /// tests. We suggest to use a sign test to extract a random Boolean value.
@@ -42,7 +44,7 @@ const STATE_SIZE: usize = 2;
 /// (http:https://xoroshiro.di.unimi.it/xoroshiro128plus.c)
 ///
 /// # Parallelism
-/// The RngJump implementation is equivalent to 2^64 calls to next_u64().
+/// The `RngJump` implementation is equivalent to 2^64 calls to `next_u64`().
 /// Used to generate 2^64 non-overlapping subsequences for parallel
 /// computations.
 #[derive(Copy, Clone)]
@@ -94,7 +96,7 @@ impl<'a> SeedableRng<&'a [u64]> for Xoroshiro128 {
 impl Rand for Xoroshiro128 {
  fn rand<R: Rng>(other: &mut R) -> Xoroshiro128 {
  let mut key: [u64; STATE_SIZE] = [0; STATE_SIZE];
- for word in key.iter_mut() {
+ for word in &mut key {
  *word = other.gen();
  }
  SeedableRng::from_seed(&key[..])
@@ -107,9 +109,9 @@ impl RngJump for Xoroshiro128 {
  let mut s0: u64 = 0;
  let mut s1: u64 = 0;
 
- for i in 0..JUMP.len() {
+ for i in &JUMP {
  for b in 0..64 {
- if (JUMP[i] & 1 << b) != 0 {
+ if (i & 1 << b) != 0 {
  s0 ^= self.0[0];
  s1 ^= self.0[1];
  }

src/xorshift1024.rs

@@ -8,6 +8,8 @@
 
 //! The Xorshift1024* random number generator.
 
+#![cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
+
 use std::num::Wrapping as w;
 
 use rand::{Rand, Rng, SeedableRng};
@@ -36,7 +38,7 @@ const STATE_SIZE: usize = 16;
 /// (http:https://xoroshiro.di.unimi.it/xorshift1024star.c)
 ///
 /// # Parallelism
-/// The RngJump implementation is equivalent to 2^512 calls to next_u64().
+/// The `RngJump` implementation is equivalent to 2^512 calls to `next_u64`().
 /// Used to generate 2^512 non-overlapping subsequences for parallel
 /// computations.
 #[derive(Clone, Copy)]
@@ -108,7 +110,7 @@ impl<'a> SeedableRng<&'a [u64]> for Xorshift1024 {
 impl Rand for Xorshift1024 {
  fn rand<R: Rng>(other: &mut R) -> Xorshift1024 {
  let mut key: [u64; STATE_SIZE] = [0; STATE_SIZE];
- for word in key.iter_mut() {
+ for word in &mut key {
  *word = other.gen();
  }
  SeedableRng::from_seed(&key[..])
@@ -119,11 +121,11 @@ impl RngJump for Xorshift1024 {
  fn jump(&mut self, count: usize) {
  for _ in 0..count {
  let mut t: [u64; 16] = [0; 16];
- for i in 0..JUMP.len() {
+ for i in &JUMP {
  for b in 0..64 {
- if (JUMP[i] & 1 << b) != 0 {
- for j in 0..16 {
- t[j] ^= self.state[(j + self.p) & 15];
+ if (i & 1 << b) != 0 {
+ for (j, t_elem) in t.iter_mut().enumerate().take(16) {
+ *t_elem ^= self.state[(j + self.p) & 15];
  }
  }
  self.next_u64();

src/xorshift128.rs

@@ -9,7 +9,9 @@
 //! The Xorshift128+ random number generator.
 
 use std::num::Wrapping as w;
+
 use rand::{Rand, Rng, SeedableRng};
+
 use RngJump;
 
 const STATE_SIZE: usize = 2;
@@ -39,7 +41,7 @@ const STATE_SIZE: usize = 2;
 /// (http:https://xoroshiro.di.unimi.it/xorshift128plus.c)
 ///
 /// # Parallelism
-/// The RngJump implementation is equivalent to 2^64 calls to next_u64().
+/// The `RngJump` implementation is equivalent to 2^64 calls to `next_u64`().
 /// Used to generate 2^64 non-overlapping subsequences for parallel
 /// computations.
 #[derive(Copy, Clone)]
@@ -86,7 +88,7 @@ impl<'a> SeedableRng<&'a [u64]> for Xorshift128 {
 impl Rand for Xorshift128 {
  fn rand<R: Rng>(other: &mut R) -> Xorshift128 {
  let mut key: [u64; STATE_SIZE] = [0; STATE_SIZE];
- for word in key.iter_mut() {
+ for word in &mut key {
  *word = other.gen();
  }
  SeedableRng::from_seed(&key[..])
@@ -102,9 +104,9 @@ impl RngJump for Xorshift128 {
  let mut s0: u64 = 0;
  let mut s1: u64 = 0;
 
- for i in 0..JUMP.len() {
+ for i in &JUMP {
  for b in 0..64 {
- if (JUMP[i] & 1 << b) != 0 {
+ if (i & 1 << b) != 0 {
  s0 ^= self.0[0];
  s1 ^= self.0[1];
  }