Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
devDependencies
were added to the@semapps/date-components
and@semapps/markdown-components
, usingyarn link
with these packages produce many problems:You are loading @emotion/react when it is already loaded. Running multiple instances may cause problems. This can happen if multiple versions are used, or if multiple builds of the same version are used.
@Laurin-W could reproduce this as well.
After more than 2 hours of search, here are the most significant issues:
react
&react-dom
are dev dependencies jaredpalmer/tsdx#64.The last issue indicate that the problem appears when React (and probably MUI) are in dev dependencies.
So I removed all the devDependencies from
@semapps/date-components
and@semapps/markdown-components
(except parcel) in this PR and it's now working fine.@mguihal @Laurin-W Can we do without these devDependencies ? What problems does it cause, except maybe eslint warnings ?
Two other solutions:
Add a reverse link to the
react
(and other packages), as noted in the two issues above. But this is very complicated to setup, because it must be changed whenever we work on another app. Plus it doesn't work if we work simultaneously on two apps (this happened for me).Revert to the pre-Parcel config (as in v0.5). But there was many problems. And I don't really know why it worked, the risk is that this problems appears again.