Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Vale workaround for StylesPath #148

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

alexeagle
Copy link
Member

Thanks @jdkato for the fix in errata-ai/vale@2139c41 so we no longer need to tell users about copying their configuration file to be relative to the styles folder.

Note, to be less breaking I didn't remove the older Vale versions. Users who pinned to those and set their StylesPath should still work, as this newly added environment variable won't be referenced.


Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • Covered by existing test cases

Thanks @jdkato for the fix in errata-ai/vale@2139c41
so we no longer need to tell users about copying their configuration file to be relative to the styles folder.
@alexeagle alexeagle merged commit 52f1f51 into main Feb 22, 2024
8 checks passed
@alexeagle alexeagle deleted the more_sarif branch February 22, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants