-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DBML support #401
Add DBML support #401
Conversation
Don't worry about the tests, I need to fix them. I will probably introduce a npm task to update the expected images. |
If failing tests are not a problem, could this small improvement be merged? |
I believe that at least one test will be failing: That's why I want to fix issues on the master branch so you can rebase. |
CI is now fixed on master, please rebase. |
Done |
Thanks! |
Could we expect a release soon please? |
With #402 closed, can't we create a new release without waiting for #397? I'm eager to get a new release so that Gitlab can update its Kroki support to the new kinds of diagrams (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/109454). |
Waiting for dbml update as well ;) |
@bobzomer @svenruegg I just released both the JavaScript 0.17.0 and Ruby version 0.8.0. Please note that GitLab is using a custom integration so you might need to update the existing logic in addition to bumping the dependency version. |
Since yuzutech/kroki#1432, kroki (either from kroki.io or from up-to-date self-hosted instance) can convert DBML diagrams (see https://www.dbml.org/home/) to SVG using dbml-renderer (https://github.com/softwaretechnik-berlin/dbml-renderer).
This pull request only aims at forwarding this new support.