Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBML support #401

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add DBML support #401

merged 1 commit into from
Jan 25, 2023

Conversation

bobzomer
Copy link
Contributor

Since yuzutech/kroki#1432, kroki (either from kroki.io or from up-to-date self-hosted instance) can convert DBML diagrams (see https://www.dbml.org/home/) to SVG using dbml-renderer (https://github.com/softwaretechnik-berlin/dbml-renderer).

This pull request only aims at forwarding this new support.

@ggrossetie
Copy link
Member

Don't worry about the tests, I need to fix them. I will probably introduce a npm task to update the expected images.

@bobzomer
Copy link
Contributor Author

Don't worry about the tests, I need to fix them. I will probably introduce a npm task to update the expected images.

If failing tests are not a problem, could this small improvement be merged?

@ggrossetie
Copy link
Member

I believe that at least one test will be failing:

https://github.com/ggrossetie/asciidoctor-kroki/blob/ff4768422d96754b6c1230fda6d42fc331f44a4c/ruby/spec/asciidoctor_kroki_spec.rb#L197

That's why I want to fix issues on the master branch so you can rebase.

@ggrossetie
Copy link
Member

CI is now fixed on master, please rebase.

@bobzomer
Copy link
Contributor Author

CI is now fixed on master, please rebase.

Done

@ggrossetie ggrossetie merged commit 5c0442b into asciidoctor:master Jan 25, 2023
@ggrossetie
Copy link
Member

Thanks!

@bobzomer
Copy link
Contributor Author

bobzomer commented Feb 1, 2023

Could we expect a release soon please?

@ggrossetie
Copy link
Member

I want to include #397 and #402 in the next release

@bobzomer
Copy link
Contributor Author

I want to include #397 and #402 in the next release

With #402 closed, can't we create a new release without waiting for #397? I'm eager to get a new release so that Gitlab can update its Kroki support to the new kinds of diagrams (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/109454).

@svenruegg
Copy link

Waiting for dbml update as well ;)

@ggrossetie
Copy link
Member

@bobzomer @svenruegg I just released both the JavaScript 0.17.0 and Ruby version 0.8.0. Please note that GitLab is using a custom integration so you might need to update the existing logic in addition to bumping the dependency version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants