Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #371 consult :to_dir option on document to resolve output directory #372

Merged
merged 2 commits into from
Jun 9, 2022
Merged

resolves #371 consult :to_dir option on document to resolve output directory #372

merged 2 commits into from
Jun 9, 2022

Conversation

mojavelinux
Copy link
Member

No description provided.

@ggrossetie
Copy link
Member

Thanks!
We should probably also update the JavaScript code:

https://github.com/Mogztter/asciidoctor-kroki/blob/4c9cb535ec6747f2e76d088944451114957002e3/src/fetch.js#L7

I will try to add a test case on both Ruby and JavaScript to make sure that the to_dir option is honored.

@ggrossetie ggrossetie force-pushed the issue-371-to-dir-option branch 2 times, most recently from 6cf552a to e75f1a5 Compare June 8, 2022 13:47
@ggrossetie ggrossetie merged commit 7394bfc into asciidoctor:master Jun 9, 2022
@ggrossetie ggrossetie mentioned this pull request Sep 2, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojavelinux @ggrossetie