Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register structurizr as a new Kroki diagram #301

Merged
merged 3 commits into from
Oct 17, 2021

Conversation

jagedn
Copy link
Contributor

@jagedn jagedn commented Oct 16, 2021

add structurizr as a new diagram supported by kroki

add structurizr as a new diagram supported by kroki
@ggrossetie
Copy link
Member

ggrossetie commented Oct 16, 2021

Thanks @jagedn
A few things we should do before merging:

If you have time to care of them that would be great. Otherwise, I will probably work on it over the coming weeks.

@jagedn
Copy link
Contributor Author

jagedn commented Oct 17, 2021

done
Let me know if I'm missing something

@ggrossetie
Copy link
Member

Looking good, thanks @jagedn
If build comes back green, I will go ahead and merge 🎉

@ggrossetie
Copy link
Member

Build is 💚
Thanks again, merging... 🚢

@ggrossetie ggrossetie changed the title register structurizr as a new kroki diagram Register structurizr as a new Kroki diagram Oct 17, 2021
@ggrossetie ggrossetie merged commit 033c8aa into asciidoctor:master Oct 17, 2021
@jagedn
Copy link
Contributor Author

jagedn commented Oct 17, 2021

Great
I will try It asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants