Set application name as referrer to make it easier to troubleshoot issues #295
Conversation
|
@Mogztter I've worked on the Ruby part and externalised the version in a file to match the usual practice but I can't find a definitive way to do in the JavaScript part and specially how to get the version of Antora, do you have a suggestion about how to do it? |
| ::OpenURI.open_uri(uri, 'r', &:read) | ||
| uri = URI(uri) | ||
| request = ::Net::HTTP::Get.new(uri) | ||
| request['Content-Type'] = 'text/plain' |
There was a problem hiding this comment.
I don't think we need to set the Content-Type since we don't send anything to the server.
|
@Mogztter I've applied your feedbacks, still it only works for the Ruby part of the lib, shall I do something for the JavaScript part or not? |
|
Thanks, it looks good!
If you want to take a stab at it, then go for it 😄 |
I'd prefer another PR, but I would need some help because I don't see how to implement it (it's not a JS problem but a "how to retrieve the version?" problem) |
Perfect, then I will proceed and merge this pull request.
You can require the const pkg = require('../package.json')
console.log(pkg.version) |
|
@archiloque Let me know if you think you will have time to work on it. I want to publish a new release this week and ideally I would like to include this feature. Thanks 🙌🏻 |
|
@Mogztter I should be able to this evening |
|
Excellent 👍🏻 |
No description provided.