Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rubocop and other gems + fix errors #294

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Update Rubocop and other gems + fix errors #294

merged 4 commits into from
Sep 14, 2021

Conversation

archiloque
Copy link
Contributor

When working on the project I have some errors because I'm using Ruby 3.0 and the Rubobop version used by the project is not aware of this version so I get an error message (Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7).

I have update Rubocop and took the opportunity to update the other gems at the same time since they don't have any impact.

After running the auto fix, I manually fixed the issues that have a low impact on the code and disable checks in the files for the other ones, the number of changes seems reasonable.

I also enabled the new rules for Rubocop as suggested bu the doc.

I also added the new rubocop-rake gem since it has no impact but I didn't added rubocop-rspec because it detects a lot of violations which should have a big impact on the code.

If you want I can add it and fix the violations, I wanted to know what you prefer before doing the required work, let me know what you prefer.

ruby/.rubocop.yml Outdated Show resolved Hide resolved
@ggrossetie
Copy link
Member

Looks good, I would rather leave rubocop-rake out for now. I don't think we need it, one less dependency, one less thing to worry about 😄

@archiloque
Copy link
Contributor Author

archiloque commented Sep 14, 2021

Looks good, I would rather leave rubocop-rake out for now. I don't think we need it, one less dependency, one less thing to worry about 😄

I've removed it, I also took the opportunity to bump the required ruby/.ruby-version to make it match the one I added in ruby/.rubocop.yml (I forgot I added it), tell me if you prefer to keep the 2.6 version.

@ggrossetie
Copy link
Member

ggrossetie commented Sep 14, 2021

I've removed it, I also took the opportunity to bump the required ruby/.ruby-version to make it match the one I added in ruby/.rubocop.yml (I forgot I added it), tell me if you prefer to keep the 2.6 version.

Perfect, I'm fine with Ruby 2.7.
Ruby 2.6 is already in "security maintenance", so it's probably better to use Ruby 2.7 as the minimum version: https://www.ruby-lang.org/en/downloads/branches/

Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏻

@ggrossetie ggrossetie merged commit 369af7f into asciidoctor:master Sep 14, 2021
@archiloque archiloque deleted the upgrade-rubocop branch September 14, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants