Ruby: log via Asciidoctor logger to provide the user with a file name

[ahus1]

… and line number in the log, plus redirection of log content in IDEs.

I increased the "Metrics/AbcSize" as I didn't know a good refactoring for this method to stay below that limit. I'd appreciate a hint or help here.

Something I found: the log line will point at...

• the first line of the block (the "----") for a block processor
• the the block macro for block macro

I started to pass down this information to KrokiProcessor.process, but then Rubocop complained about too many parameters. Then I settled with "leave it as it is" :-/ ... see this snippet on how to adjust line numbers for logging.

[ahus1]

rebased, not sure why JS test failed in Windows - unstable test?

[ggrossetie]

rebased, not sure why JS test failed in Windows - unstable test?

Probably, we might need to adjust the timeout...

[ggrossetie]

I think we need to merge #171 first (or at least we will need to update #171 if we decide to merge this change first).

If you have time to review #171 that would be great. I did these changes to allow a better integration with GitLab. I guess the Intellij IDEA plugin would also benefit from these changes but I didn't check carefully.

[ggrossetie]

I merged #171, we need to rebase this pull request.
If you want I can take care of it, just let me know 😉

[ggrossetie]

@ahus1 Sorry I lost track but I think it's ready to go, right?

[ahus1]

@Mogztter - I've finally update the code, and updated also the other places where a logger was used.

To be able to use message_with_context I added include Asciidoctor::Logging in a total of 3 places.

I see that the code allows to pass a logger as a parameter. I had a look around and saw no code fragment using it. I wonder: What was the intention to not use the logger that is provided by include Asciidoctor::Logging? Did you plan to use a logger injection for testing?

I suppose it is now ready for review.

[ggrossetie]

To be able to use message_with_context I added include Asciidoctor::Logging in a total of 3 places.

Sounds reasonable.

I see that the code allows to pass a logger as a parameter. I had a look around and saw no code fragment using it. I wonder: What was the intention to not use the logger that is provided by include Asciidoctor::Logging? Did you plan to use a logger injection for testing?

Yes, but also for integration. For instance, GitLab is using its own logger so it's important to be able to provide a different logger.

I suppose it is now ready for review.

OK, thanks, I will take a look.

[ggrossetie]

LGTM 👍🏻
I will wait a bit if someone else want to review before merging.