Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commonjs package manager support #119

Closed
alexilyaev opened this issue Sep 25, 2015 · 5 comments
Closed

Add commonjs package manager support #119

alexilyaev opened this issue Sep 25, 2015 · 5 comments

Comments

@alexilyaev
Copy link
Contributor

Can we add support for loading the ngCsv as a CommonJS module?

See example of Angular UI-Router:
https://github.com/angular-ui/ui-router/blob/master/release/angular-ui-router.js

This will allow doing:

var ngCsv = require('ng-csv');

angular.module('admin', [
    ngCsv
])

Instead of hard coding the module name.

@asafdav
Copy link
Owner

asafdav commented Sep 25, 2015

Sounds like a great idea, would you like to pull request ?

On Fri, Sep 25, 2015 at 3:44 PM, Alex Ilyaev [email protected]
wrote:

Can we add support for loading the ngCsv as a CommonJS module?

See example of Angular UI-Router:

https://github.com/angular-ui/ui-router/blob/master/release/angular-ui-router.js

This will allow doing:

var ngCsv = require('ng-csv');

angular.module('admin', [
ngCsv
])

Instead of hard coding the module name.


Reply to this email directly or view it on GitHub
#119.

asafdav added a commit that referenced this issue Sep 27, 2015
Add CommonJS package manager support (closes #119)
@alexilyaev
Copy link
Contributor Author

Cool, when can we expect it to be on NPM?

@asafdav
Copy link
Owner

asafdav commented Sep 28, 2015

Now :) I'd appreciate it if you could report back that it works well for you.

@alexilyaev
Copy link
Contributor Author

Confirmed.

@asafdav
Copy link
Owner

asafdav commented Sep 29, 2015

Great thank you!

On Tue, Sep 29, 2015 at 11:53 AM, Alex Ilyaev [email protected]
wrote:

Confirmed.


Reply to this email directly or view it on GitHub
#119 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants