Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): using h1 and h2 instead of pure divs to improve a11y #42

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

arturmiz
Copy link
Owner

@arturmiz arturmiz commented Dec 3, 2018

No description provided.

@arturmiz arturmiz added the a11y Accessibility issues label Dec 3, 2018
@arturmiz arturmiz self-assigned this Dec 3, 2018
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          25       25           
  Lines         103      103           
  Branches       19       19           
=======================================
  Hits          101      101           
  Misses          2        2
Impacted Files Coverage Δ
src/components/header/Header.vue 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc7b52...7b3a190. Read the comment docs.

@arturmiz arturmiz merged commit 1b118b5 into master Dec 3, 2018
@arturmiz arturmiz deleted the fix/header/a11y-improvements branch December 3, 2018 20:59
@arturmiz arturmiz added this to the v0.5.0 milestone Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant