Added proxy support to client #40
Conversation
|
Thank u, can u make a new PR to develop branch instead of master, so we can work more separately on this feature? |
src/Components/ClientConfig.php
Outdated
| @@ -19,6 +17,12 @@ class ClientConfig | |||
| private $fragmentSize = WscCommonsContract::DEFAULT_FRAGMENT_SIZE; | |||
| private $context; | |||
|
|
|||
|
|
|||
| private $has_proxy = false; | |||
There was a problem hiding this comment.
Let's support the lib standard of camelCase properties naming - e.g.: $hasProxy would be preferable and so on for others
src/Components/WscMain.php
Outdated
|
|
||
|
|
||
| //do we have a proxy? | ||
| $proxy_ip = ''; |
There was a problem hiding this comment.
U have an instance of ClientConfig here via $config prop, so there is no reason to create all these vars locally
src/Components/WscMain.php
Outdated
| $proxy_port = ''; | ||
| $proxy_auth = ''; | ||
|
|
||
| if ($this->config->getProxy($proxy_ip, $proxy_port, $proxy_auth)) { |
There was a problem hiding this comment.
$this-config->hasProxy would be a better design for checking whether it is a proxy or not and then if it is - $this-config->getProxyHost(), getProxyPort, get ProxyAuth etc
|
The request feature is good, we just need to set all things up to provide more compatible code with the code-base. |
|
changes have been made |
|
Good work - thx |
Proxies are not a supported param by stream_socket_client() and is the http.proxy option is completely ignored. php.net/manual/en/context.socket.php
The change will first connect to a tcp proxy, issue the CONNECT command to the host, and then use the proxy to relay any data to the WebSocket.