Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compare table columns for no reference (issue #114) #116

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

cheungrowan
Copy link
Contributor

This provides a fix for issue #114

  • Only creates the reference output column header if reference output is present for the data
  • Updates the test suite state settings so that the compare table is reloaded correctly. Before making this change, the correct column headers would only be displayed on refresh.
  • Had to update the versions of the types packages to build successfully

New table view for readability (no reference) test suite:
Screen Shot 2024-04-10 at 12 04 19 AM

Copy link
Collaborator

@fryz fryz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution :)

@fryz
Copy link
Collaborator

fryz commented Apr 19, 2024

going to merge because these changes are all FE (and clearly our build is flaking because those are BE validations)

@fryz fryz merged commit 6b71449 into arthur-ai:main Apr 19, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants