Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Slavic Locales for Future Dehumanize Support #992

Merged
merged 2 commits into from
Aug 1, 2021

Conversation

anishnya
Copy link
Member

@anishnya anishnya commented Jun 16, 2021

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

This is a refactor of the locales that derive from the Slavic Base Locale. These changes add what I believe to be more clarity to these locales implementations. In addition, these changes make these locales conform to a single unified locale standard I am trying to make, so that all locales will support dehumanize.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #992 (c17213e) into master (95838a8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #992   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2150      2150           
  Branches       339       339           
=========================================
  Hits          2150      2150           
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95838a8...c17213e. Read the comment docs.

@anishnya anishnya changed the title Refactor of Slavic Locales for Future Dehumanize support Refactor of Slavic Locales for Future Dehumanize Support Jun 16, 2021
Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I don't think there's a need to do the paucal portion we discussed..

@anishnya anishnya merged commit 326c62c into arrow-py:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants