Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sami locale #989

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Add Sami locale #989

merged 3 commits into from
Jun 14, 2021

Conversation

cyriaka90
Copy link
Contributor

@cyriaka90 cyriaka90 commented Jun 10, 2021

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Adds Sami locale. :)

References for example: https://en.wikivoyage.org/wiki/Northern_S%C3%A1mi_phrasebook

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #989 (1d1e6c7) into master (197bd64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #989   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2074      2083    +9     
  Branches       332       332           
=========================================
+ Hits          2074      2083    +9     
Impacted Files Coverage Δ
arrow/constants.py 100.00% <ø> (ø)
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197bd64...1d1e6c7. Read the comment docs.

@anishnya anishnya self-requested a review June 10, 2021 23:24
@anishnya anishnya requested a review from krisfremen June 10, 2021 23:32
@anishnya
Copy link
Member

@cyriaka90, I think this locale should support dehumanize. Do you mind adding the locale into the dehumanize test cases and in constants.py? Other than that, LGTM. @krisfremen any additional thoughts?

@cyriaka90
Copy link
Contributor Author

Of course, I can do that! :) I will update the PR accordingly soon.

@cyriaka90
Copy link
Contributor Author

I added the locale into the dehumanize test cases and in constants.py.

For the tests to succeed I added a blank space for future - I couldn't find a preposition/postposition for Sami here, so I assumed none is needed here, but I'm not sure what to do here to satisfy the tests more elegantly:

future = "{0} " # NOTE: couldn't find preposition for Sami here, none needed?

Any thoughts?

@anishnya
Copy link
Member

couldn't find a preposition/postposition for Sam

That is the most elegant solution I can think of as well. The Basque locale had a similar issue as well when it comes to supporting dehumanize (we don't have a future proposition for Basque too). I think for now, I'll merge in this PR in and I'll create a separate issue and see what I can do on the dehumanize end of things for this.

As always, great work @cyriaka90! Also, if you have any thoughts on what should be added to the locale implementation guide, please feel free to add them on #983.

@anishnya anishnya closed this Jun 14, 2021
@anishnya anishnya reopened this Jun 14, 2021
@anishnya anishnya merged commit 7c9632c into arrow-py:master Jun 14, 2021
@cyriaka90
Copy link
Contributor Author

That is the most elegant solution I can think of as well. The Basque locale had a similar issue as well when it comes to supporting dehumanize (we don't have a future proposition for Basque too). I think for now, I'll merge in this PR in and I'll create a separate issue and see what I can do on the dehumanize end of things for this.

Alright, thanks! :)

As always, great work @cyriaka90! Also, if you have any thoughts on what should be added to the locale implementation guide, please feel free to add them on #983.

Thank you! I will do so!

@cyriaka90 cyriaka90 deleted the sami_locale branch June 16, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants