-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serbian locale #980
Add Serbian locale #980
Conversation
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2056 2074 +18
Branches 330 332 +2
=========================================
+ Hits 2056 2074 +18
Continue to review full report at Codecov.
|
@cyriaka90 hvala lepo! we have an ongoing issue to discuss how to implement native alphabets vs latin alphabet in #974 |
Thanks for the hint! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than the small comment mixup!
arrow/locales.py
Outdated
"septembar", # октобар | ||
"oktobar", # септембар |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments seem to be reversed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes, of course - I'll change it! :D
Merged in. Keep up the great work @cyriaka90! |
Thank you! :D |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.Description of Changes
Adds Serbian locale. Serbian actually can be written with both Latin or Cyrillic script - I chose the Latin one here. Not sure if arrow could support both?