Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serbian locale #980

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Add Serbian locale #980

merged 3 commits into from
Jun 10, 2021

Conversation

cyriaka90
Copy link
Contributor

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Adds Serbian locale. Serbian actually can be written with both Latin or Cyrillic script - I chose the Latin one here. Not sure if arrow could support both?

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #980 (020ae47) into master (3606a80) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #980   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2056      2074   +18     
  Branches       330       332    +2     
=========================================
+ Hits          2056      2074   +18     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3606a80...020ae47. Read the comment docs.

@krisfremen
Copy link
Member

@cyriaka90 hvala lepo!

we have an ongoing issue to discuss how to implement native alphabets vs latin alphabet in #974

@cyriaka90
Copy link
Contributor Author

we have an ongoing issue to discuss how to implement native alphabets vs latin alphabet in #974

Thanks for the hint!

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the small comment mixup!

arrow/locales.py Outdated
Comment on lines 5026 to 5027
"septembar", # октобар
"oktobar", # септембар
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments seem to be reversed :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, of course - I'll change it! :D

@anishnya anishnya merged commit 197bd64 into arrow-py:master Jun 10, 2021
@anishnya
Copy link
Member

Merged in. Keep up the great work @cyriaka90!

@cyriaka90
Copy link
Contributor Author

Thank you! :D

@cyriaka90 cyriaka90 deleted the serbian_locale branch June 11, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants