Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Arabic Locale For Dehumanize Support #1028

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Conversation

anishnya
Copy link
Member

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Refactor of Arabic Locale for future dehumanize support. The main reason for this change is that we need a way to convey the actual delta some of those strings represent. Rather than creating a look-up table, or some kind of translation logic, I think it is easier to just have the key be the string representation of an integer. This way, dehumanize call easily interpret this. This will make more sense, when I push the actual dehumanize update PR (after the backlog of locale refactor PRs get merged in :) ).

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1028 (8f4e1b6) into master (6b9e427) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1028   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2161      2161           
  Branches       340       340           
=========================================
  Hits          2161      2161           
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9e427...8f4e1b6. Read the comment docs.

@anishnya anishnya merged commit 906802c into master Aug 29, 2021
@anishnya anishnya deleted the arabic-refactor branch August 29, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants