-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zulu locale #1002
Add Zulu locale #1002
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2111 2131 +20
Branches 333 335 +2
=========================================
+ Hits 2111 2131 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This locale actually wouldn't support dehumanize at the moment. Within tests/test_arrow.py we have a separate list of locales to test on since not all locales support the week format. If you add this locale to that test list, it would fail. At the moment, any locale that has Mapping[TimeFrameLiteral, Union[Mapping[str, str], str]]
doesn't support dehumanize.
Everything else is good to go, just for the time being this locale wouldn't support dehumanize. (I'm working on a version of dehumanize that will :) )
Ah, alright, thanks for pointing that out! :) So should I just remove Zulu from the dehumanize_locales? |
@cyriaka90 Yes. |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.Description of Changes
Adds Zulu locale. :)