Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zulu locale #1002

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Add Zulu locale #1002

merged 2 commits into from
Jul 7, 2021

Conversation

cyriaka90
Copy link
Contributor

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Adds Zulu locale. :)

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1002 (1194234) into master (aa0e805) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2111      2131   +20     
  Branches       333       335    +2     
=========================================
+ Hits          2111      2131   +20     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0e805...1194234. Read the comment docs.

Copy link
Member

@anishnya anishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This locale actually wouldn't support dehumanize at the moment. Within tests/test_arrow.py we have a separate list of locales to test on since not all locales support the week format. If you add this locale to that test list, it would fail. At the moment, any locale that has Mapping[TimeFrameLiteral, Union[Mapping[str, str], str]] doesn't support dehumanize.

Everything else is good to go, just for the time being this locale wouldn't support dehumanize. (I'm working on a version of dehumanize that will :) )

@cyriaka90
Copy link
Contributor Author

Ah, alright, thanks for pointing that out! :) So should I just remove Zulu from the dehumanize_locales?

@anishnya
Copy link
Member

anishnya commented Jul 7, 2021

@cyriaka90 Yes.

@cyriaka90
Copy link
Contributor Author

Done :)

Copy link
Member

@anishnya anishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anishnya anishnya merged commit 37b45da into arrow-py:master Jul 7, 2021
@cyriaka90 cyriaka90 deleted the zulu_locale branch July 8, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants