Add missing methods to support incremental rebalance #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff48ccc
to
4139963
Compare
arnaud-lb
reviewed
Jan 5, 2024
kafka_consumer.c
Outdated
Comment on lines
252
to
256
| /* {{{ proto void RdKafka\KafkaConsumer::incrementalAssign(array $topics) | ||
| Incremental assignment of partitions to consume */ | ||
| PHP_METHOD(RdKafka_KafkaConsumer, incrementalAssign) | ||
| { | ||
| #if RD_KAFKA_VERSION >= 0x010600ff |
There was a problem hiding this comment.
Hi Arnaud and thank you too :)
did as you said
770ba92
to
c76c74b
Compare
c76c74b
to
7f9d31e
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::incrementalAssign()and::incrementalUnassign()consumer methods are used in rebalance callback instead of::assign()when cooperative-sticky partition assignment strategy in charge.