Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some modbus salve code and LICENSE file #42

Merged
merged 2 commits into from
May 21, 2019

Conversation

armink
Copy link
Owner

@armink armink commented May 21, 2019

@pvyleta
Copy link

pvyleta commented May 21, 2019

Perfect, thanks a lot! I really appreciate your effort.

One last thing: If possible, could you change the license for this gitHub repository so that it is clear this code is possible to be used under BSD? I think this would make life much easier to many developers, and also more people would consider your code for their projects.

https://github.com/armink/FreeModbus_Slave-Master-RTT-STM32/blob/master/LICENSE

@armink
Copy link
Owner Author

armink commented May 21, 2019

The LICENSE file is already changed. Please see
https://github.com/armink/FreeModbus_Slave-Master-RTT-STM32/pull/42/files#diff-9879d6db96fd29134fc802214163b95aR1

I will also explain the license on the readme.

@pvyleta
Copy link

pvyleta commented May 21, 2019

OK, I did not realized that. I was using the link on main page of GitHub, and only wanted to ensure it will be changed as well:
image

@armink
Copy link
Owner Author

armink commented May 21, 2019

when this pr is merge the main page of GitHub will change

@armink armink merged commit 2fb1a88 into master May 21, 2019
@armink armink deleted the update_from_cwalter-at branch May 21, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants