Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few adjustments in big integer shr_assign #792

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

tcoratger
Copy link
Contributor

  • If the number of bits shifted is larger than N * 64, the function can be exited at the beginning without having to do the rest of the calculations.
  • As the limbs are traversed from the end to the beginning, it is generally less expensive to do a while starting from the end to avoid looking for an index at the opposite end of the table at each iteration.

@tcoratger tcoratger requested review from a team as code owners February 26, 2024 21:57
@tcoratger tcoratger requested review from Pratyush, mmagician and weikengchen and removed request for a team February 26, 2024 21:57
ff/src/biginteger/mod.rs Outdated Show resolved Hide resolved
ff/src/biginteger/mod.rs Outdated Show resolved Hide resolved
tcoratger and others added 2 commits February 27, 2024 08:52
Co-authored-by: Pratyush Mishra <[email protected]>
Co-authored-by: Pratyush Mishra <[email protected]>
@Pratyush Pratyush added this pull request to the merge queue Feb 27, 2024
Merged via the queue into arkworks-rs:master with commit 23d32e9 Feb 27, 2024
12 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants