Add a few simplifications around Mont inverse #788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
div2
method ofBigInt
, we traverse the members in the opposite direction (big endian order) with a loop which until now was carried out in the little endian order. Therefore, in each iteration of the loop, the calculation ofN - i - 1
was necessary. If we go through the limbs in the opposite direction with a while as I propose here, the calculation is no longer carried out on each pass, because we take the memberi
directly.inverse
method of the Montgomery back end, when we exit the following piece of code:there is no need for the else, because the rest will necessarily take place if
a
is not zero. Therefore, I removed the else here to avoid unnecessary indentations.