Explicitly taking into account a + (-a) for add_assign
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, in the
add_assignfunction forProjectivestructure, in case of a + (-a) operation, all coefficients are calculated as in the case of a classic addition a + b with a and b different (Cost: 11M + 5S + 9add + 4*2).However, this scenario can be simplified, by taking it into account explicitly in the logic to avoid doing all the unnecessary calculations.
Indeed, we know that if
u1 == u2 && s1 != s2then it is a + (-a) and therefore we can return the point at infinity directly (zero) without any further calculation necessary.