Add Zero trait bound to Polynomial
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
approved these changes
Nov 19, 2020
|
Ahh I forgot to ask you to update the changelog; do you mind submitting a new PR for that? |
ryanleh
added a commit
to ryanleh/algebra
that referenced
this pull request
Nov 19, 2020
ryanleh
added a commit
to ryanleh/algebra
that referenced
this pull request
Nov 19, 2020
ryanleh
added a commit
to ryanleh/marlin
that referenced
this pull request
Nov 19, 2020
Pratyush
pushed a commit
that referenced
this pull request
Nov 19, 2020
Pratyush
pushed a commit
to arkworks-rs/marlin
that referenced
this pull request
Nov 19, 2020
weikengchen
added a commit
to arkworks-rs/marlin
that referenced
this pull request
Dec 10, 2020
* Update for arkworks-rs/algebra#53 * Automatically pad the formatted input size to 2^k (#47) * support public input that is not 2^k * Update src/lib.rs Co-authored-by: Pratyush Mishra <[email protected]> * fmt Co-authored-by: Pratyush Mishra <[email protected]> * Add the benchmark (#48) * add bench * fix * fmt * multithread * update the remark Co-authored-by: Ryan Lehmkuhl <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]>
weikengchen
added a commit
to arkworks-rs/marlin
that referenced
this pull request
Dec 17, 2020
…master` (#52) * Update for arkworks-rs/algebra#53 * Automatically pad the formatted input size to 2^k (#47) * support public input that is not 2^k * Update src/lib.rs Co-authored-by: Pratyush Mishra <[email protected]> * fmt Co-authored-by: Pratyush Mishra <[email protected]> * Add the benchmark (#48) * add bench * fix * fmt * multithread * update the remark * Remove circuit `C` and some lifetime specifiers from the type (#50) * remove c in type * fix * remove an unnecessary clone * Add serialization for Proof (#51) * add serialization for Proof * add unchecked serialization * fix bench and add uncompressed serialization * fix bench Co-authored-by: Ryan Lehmkuhl <[email protected]> Co-authored-by: Pratyush Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were already required methods for
Polynomial, but moving it to the appropriate trait allows us to generically handle polynomials as additive shares (which require an additive identity).