Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup coset fft #176

Merged
merged 9 commits into from
Jan 14, 2021
Merged

Speedup coset fft #176

merged 9 commits into from
Jan 14, 2021

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jan 14, 2021

Description

Speeds up coset FFTs by N field multiplications. It does this by combining the final multiplication by |D|^{-1} with the coset shift


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@@ -37,13 +38,14 @@ pub(crate) fn compute_powers_and_mul_by_const_serial<F: Field>(
.collect()
}

#[allow(unused)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting allow(unused) here, since we want to benchmarking changing roots of unity with this function

poly/src/domain/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the duplication comment

@ValarDragon
Copy link
Member Author

Benchmarked on snarky. This appears to apply a speedup of approximately 5%. (Started benchmark at 2^15, where it was 5.5%. At 2^20 its 4.25%)

@Pratyush
Copy link
Member

That's awesome =)

@ValarDragon ValarDragon merged commit 8d76d18 into master Jan 14, 2021
@ValarDragon ValarDragon deleted the speedup_coset_fft branch January 14, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants