Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.md - put the GitHub token content in a collapsed section #135

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Mar 10, 2024

git.md - put the GitHub token content in a collapsed section

git.md - put the GitHub token content in a collapsed section
git.md - add whitespace to token section modifications to attempt appeasing the Markdown linter
@mthiel117
Copy link
Collaborator

Please change to not use inline HTML.

Also, please use mkdocs serve to review your desired changes.

workshops/git.md Outdated
@@ -280,7 +280,10 @@ If you do not have a GitHub account, you can create one **[here](https://github.

### **Create a GitHub personal access token**

To push your local repo to GitHub, you will need a Personal Access Token. From your **GitHub** account, click through the following path to generate a new personal access token. **Profile --> Settings --> Developer Settings --> Personal Access Tokens --> Tokens (classic) --> Generate new token (classic)**
<details>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to not use inline HTML.

Also, please use mkdocs serve to review your desired changes.

workshops/git.md Outdated
@@ -280,7 +280,10 @@ If you do not have a GitHub account, you can create one **[here](https://github.

### **Create a GitHub personal access token**

To push your local repo to GitHub, you will need a Personal Access Token. From your **GitHub** account, click through the following path to generate a new personal access token. **Profile --> Settings --> Developer Settings --> Personal Access Tokens --> Tokens (classic) --> Generate new token (classic)**
<details>
<summary>When not using the ATD lab IDE, generate a GitHub personal access token (click to expand)</summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to not use inline HTML.

Also, please use mkdocs serve to review your desired changes.

@mjbear
Copy link
Contributor Author

mjbear commented Mar 11, 2024

Please change to not use inline HTML.

Also, please use mkdocs serve to review your desired changes.

Certainly.
I should have used an mkdocs admonition instead of the general collapsible HTML markup. Apologies.

Will do.

@mjbear
Copy link
Contributor Author

mjbear commented Mar 11, 2024

@mthiel117
This has been remedied by using an admonition for the collapsed section.

Copy link
Collaborator

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great add, thank you

@JulioPDX
Copy link
Collaborator

fixes #127

Copy link
Collaborator

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like it. Thanks

@mthiel117 mthiel117 merged commit de60ca5 into aristanetworks:main Mar 14, 2024
2 checks passed
@mjbear mjbear deleted the git_token branch March 25, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants