Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jinja-yaml - add whitespace around variable in curly braces #131

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Mar 7, 2024

jinja-yaml - add whitespace around variable in curly braces based on best practices in official Jinja documentation

ex: {{vrf}} becomes {{ vrf }}

Copy link
Collaborator

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebased from previous PR 130

Copy link
Collaborator

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebased from previous PR 130

jinja-yaml - add whitespace around variable in curly braces based on best practices in official Jinja documentation

ex: {{vrf}} becomes {{ vrf }}
@mjbear
Copy link
Contributor Author

mjbear commented Mar 11, 2024

Rebased from current position of upstream's main branch.

@mthiel117
Will go ahead and rebase PR #132 to this current PR. ;-)

Copy link
Collaborator

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Woohoo

Copy link
Collaborator

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Michael

@mthiel117 mthiel117 merged commit f0bd2d5 into aristanetworks:main Mar 13, 2024
2 checks passed
@mjbear mjbear deleted the jinja_spacing branch March 25, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants