Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar modifications in jinja-yaml.md #130

Merged
merged 19 commits into from
Mar 11, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Mar 7, 2024

Grammar modifications in jinja-yaml.md

jinja-yaml - comments: modify > modifying
jinja-yaml - correct the it's contraction
jinja-yaml - make circuit ID two words
jinja-yaml - fix vrf_values typo
jinja-yaml - remove a for and change out to our
@mjbear
Copy link
Contributor Author

mjbear commented Mar 9, 2024

@mthiel117
I'm not trying to be a pest, but wanted to let you know I put in a few PRs. (And may have a few more in the works.)

Thank you!
-M

mjbear added 14 commits March 9, 2024 17:58
jinja-yaml
- JINJA > Jinja
- section > sections (plural)
jinja-yaml
- replace "and shown below" with as shown below
- replace "like such" with as shown below
jinja-yaml - replace "day to day" with day-to-day
jinja-yaml - replace "key value pair" with key-value pair (hyphenated)
jinja-yaml - add word key in parentheses to describe the data label and tie it to the key-value concept in the previous sentence
jinja-yaml - double edged > double-edged (hypenated)
jinja-yaml - several grammar tweaks
jinja-yaml - grammar regarding looping over dictionaries
jinja-yaml - vxlan interface config grammar
jinja-yaml - correct several contractions
- lets > let's
- whats > what's
jinja-yaml - improve ipaddr netmask filter description
jinja-yaml - ipaddr address filter grammar
jinja-yaml - improve grammar of rsrv/ntps variable descriptions
jinja-yaml
- add the word filter to the ipaddr() heading
- add the word filter to the join() heading
- reword the join filter explanation
Copy link
Collaborator

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mthiel117 mthiel117 merged commit 33fb188 into aristanetworks:main Mar 11, 2024
2 checks passed
@mjbear mjbear deleted the jinja_grammar branch March 25, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants