Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add needs to build step #101

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add needs to build step #101

merged 2 commits into from
Aug 30, 2023

Conversation

JulioPDX
Copy link
Collaborator

@JulioPDX JulioPDX commented Aug 30, 2023 •
edited
Loading

Adding needs to prevent build from running on pre_commit fail.

@JulioPDX JulioPDX changed the title edit Add needs to build step Aug 30, 2023
mthiel117
mthiel117 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@mthiel117 mthiel117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthiel117 mthiel117 merged commit 1885931 into aristanetworks:main Aug 30, 2023
6 checks passed
@JulioPDX JulioPDX deleted the workflow-test branch October 18, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthiel117 mthiel117 mthiel117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulioPDX @mthiel117