yum.conf supplied by this module overwrites other changes users have made #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class for making sure that gpgcheck=1 in yum.conf has a hard-coded file that is used as the source. Any other changes that have been made to that configuration file will be overwritten. Instead of using a source file, it would be better to use augeas to just update that one configuration parameter that is required. The class in question is cis::linuxcontrols::c0003
Also, the current implementation sets the ownership and permissions of yum.conf. While that's a good idea, that isn't in the CIS benchmarks and probably shouldn't be included in the Puppet CIS module.
I'll submit a pull request that uses Augeas to update this setting.