Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Workflow-controller panic when stop a wf using plugin. Fixes #9587 #9690

Merged
merged 1 commit into from
Sep 29, 2022
+4 −1
Merged

fix: Workflow-controller panic when stop a wf using plugin. Fixes #9587 #9690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Workflow-controller panic when stop a wf using plugin. Fixes #9587 
Signed-off-by: yangxue.chen <[email protected]>
  • Loading branch information
yangxue.chen committed Sep 29, 2022
commit 37c3fd223daa67deb5563669ab0779e93f670489
5 changes: 4 additions & 1 deletion workflow/controller/exec_control.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ func (woc *wfOperationCtx) applyExecutionControl(pod *apiv1.Pod, wfNodesLock *sy
}

nodeID := woc.nodeID(pod)
node := woc.wf.Status.Nodes[nodeID]
node, ok := woc.wf.Status.Nodes[nodeID]
if !ok {
return
}
//node is already completed
if node.Fulfilled() {
return
Expand Down