-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump golangci-lint to v1.49.0 #9639
Conversation
Signed-off-by: William Van Hevelingen <[email protected]>
- typecheck | ||
- unparam | ||
- unused | ||
- varcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three removed linters have been replaced by unused
which is enabled
exclude-rules: | ||
- path: server/artifacts/artifact_server_test.go | ||
text: "response body must be closed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was a false positive but let me know if there is an easy way to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it flaky or consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistent
Signed-off-by: William Van Hevelingen <[email protected]>
Signed-off-by: William Van Hevelingen <[email protected]>
Signed-off-by: William Van Hevelingen <[email protected]>
Signed-off-by: William Van Hevelingen <[email protected]>
* chore(deps): bump golangci-lint to v1.49.0 Signed-off-by: William Van Hevelingen <[email protected]> * fix: lint newlines Signed-off-by: William Van Hevelingen <[email protected]> * fix: remove extra newline Signed-off-by: William Van Hevelingen <[email protected]> * fix: Address feedback Signed-off-by: William Van Hevelingen <[email protected]> * fix: typo Signed-off-by: William Van Hevelingen <[email protected]> Signed-off-by: William Van Hevelingen <[email protected]> Signed-off-by: yangxue.chen <[email protected]>
* chore(deps): bump golangci-lint to v1.49.0 Signed-off-by: William Van Hevelingen <[email protected]> * fix: lint newlines Signed-off-by: William Van Hevelingen <[email protected]> * fix: remove extra newline Signed-off-by: William Van Hevelingen <[email protected]> * fix: Address feedback Signed-off-by: William Van Hevelingen <[email protected]> * fix: typo Signed-off-by: William Van Hevelingen <[email protected]> Signed-off-by: William Van Hevelingen <[email protected]> Signed-off-by: juchao <[email protected]>
Signed-off-by: William Van Hevelingen [email protected]
This resolves the following error on golang 1.19