fix: avoid panic when not passing AuthSupplier #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
4086e8f
to
7d29202
Compare
pkg/apiclient/apiclient.go
Outdated
| if opts.ArgoServerOpts.HTTP1 { | ||
| return newHTTP1Client(opts.ArgoServerOpts.GetURL(), opts.AuthSupplier(), opts.ArgoServerOpts.InsecureSkipVerify, opts.ArgoServerOpts.Headers) | ||
| if opts.AuthSupplier != nil { |
There was a problem hiding this comment.
Should we check auth supplier and return error instead? Otherwise it's auth=""
There was a problem hiding this comment.
Should we check auth supplier and return error instead? Otherwise it's
auth=""
Of course, but we can only do something like below when there is no any Authentication.
apiclient.Opts{
ArgoServerOpts: ArgoServerOpts,
AuthSupplier: func() string {
return ""
},
})Signed-off-by: wujunwei <[email protected]>
5225aca
to
853b74e
Compare
alexec
approved these changes
Sep 19, 2022
terrytangyuan
approved these changes
Sep 19, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
Signed-off-by: juchao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wujunwei [email protected]
Fixes #9585
Fix panic: runtime error: invalid memory address or nil pointer dereference