Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dev-container): Fix buildkit doc for local dev #9580

Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Sep 13, 2022

The text states Configure Docker Desktop to use BuildKit: yet has "buildkit": false. This changes it to true.

Matches the Docker Desktop docs

Original PR that added this text

Signed-off-by: jmeridth [email protected]

The text states `Configure Docker Desktop to use BuildKit:`
yet has `"buildkit": false`.  Changed to `true`

Matches the [Docker Desktop docs](https://docs.docker.com/develop/develop-images/build_enhancements/#to-enable-buildkit-builds)

Signed-off-by: jmeridth <[email protected]>
@terrytangyuan terrytangyuan marked this pull request as ready for review September 13, 2022 08:47
@terrytangyuan terrytangyuan merged commit ace1798 into argoproj:master Sep 13, 2022
@jmeridth jmeridth deleted the jm/docs-development-container-buildkit branch September 13, 2022 14:45
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants