docs: Improve quickstart flow and installation docs. Fixes #9398 #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
caelan-io
reviewed
Aug 25, 2022
caelan-io
reviewed
Aug 25, 2022
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
| kubectl -n argo port-forward deployment/argo-server 2746:2746 | ||
| ``` | ||
|
|
||
| * Navigate your browser to <https://localhost:2746>. |
There was a problem hiding this comment.
Remove <> so readers can just click the link?
There was a problem hiding this comment.
This breaks the CI. (This url was also written like this previously)
There was a problem hiding this comment.
The <> chars are removed at rendering. Look at https://argoproj.github.io/argo-workflows/quick-start/ the code for which is: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/quick-start.md
| Open a port-forward so you can access the UI: | ||
|
|
||
| ```bash | ||
| kubectl -n argo port-forward deployment/argo-server 2746:2746 | ||
| ``` | ||
|
|
||
| This will serve the UI on <https://localhost:2746> | ||
| This will serve the UI on <https://localhost:2746>. Due to the self-signed certificate, you will receive a TLS error which you will need to manually approve. |
terrytangyuan
approved these changes
Aug 26, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
(argoproj#9421) * docs: Improve quickstart flow and installation docs. Fixes argoproj#9398 Signed-off-by: Tim Collins <[email protected]> * docs: Improve quickstart flow and installation docs. Fixes argoproj#9398 Signed-off-by: Tim Collins <[email protected]> * docs: Link user to configuration options Signed-off-by: Tim Collins <[email protected]> * docs: Clarify headings Signed-off-by: Tim Collins <[email protected]> * docs: Address feedback Signed-off-by: Tim Collins <[email protected]> * docs: Improve argo-serve patch explanation Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Tim Collins <[email protected]> Signed-off-by: juchao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Collins [email protected]
Fixes #9398