fix: ArtifactGC e2e test was looking for the wrong artifact names #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <[email protected]>
terrytangyuan
approved these changes
Aug 12, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…goproj#9353) Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: juchao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julie Vogelman [email protected]
Realized the test had a typo where some of the artifact names were wrong. The reason it worked before was because it's looking in Minio to make sure the artifacts were deleted, and since they were never there it confirmed it.