fix: Retry for http timeout error. Fixes #9271 #9335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
requested changes
Aug 12, 2022
workflow/artifacts/gcs/gcs.go
Outdated
| @@ -334,3 +335,7 @@ func (g *ArtifactDriver) ListObjects(artifact *wfv1.Artifact) ([]string, error) | |||
| func (g *ArtifactDriver) IsDirectory(artifact *wfv1.Artifact) (bool, error) { | |||
| return false, errors.New(errors.CodeNotImplemented, "IsDirectory currently unimplemented for GCS") | |||
| } | |||
|
|
|||
| func isTransientErr(err error) bool { | |||
| return http.IsHttpTimeoutErr(err) || isTransientGCSErr(err) | |||
There was a problem hiding this comment.
Why not adding http.IsHttpTimeoutErr to the existing isTransientGCSErr?
There was a problem hiding this comment.
There's also already isTransientError in the codebase. Consider reusing it.
jingkkkkai
force-pushed
the
retry-for-http-timeout
branch
4 times, most recently
from
f030fe7
to
08da828
Compare
Signed-off-by: Jingkai Hung <[email protected]>
jingkkkkai
force-pushed
the
retry-for-http-timeout
branch
from
08da828
to
d4e9621
Compare
terrytangyuan
approved these changes
Aug 15, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Jingkai Hung <[email protected]> Signed-off-by: Jingkai Hung <[email protected]> Signed-off-by: juchao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jingkai Hung [email protected]
Fixes #9271