Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: line return in devcontainer host file #9204

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix: line return in devcontainer host file #9204

merged 1 commit into from
Jul 22, 2022

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Jul 22, 2022

From

127.0.0.1 dex\n127.0.0.1 minio\n127.0.0.1 postgres\n127.0.0.1 mysql\n127.0.0.1 azurite

To

127.0.0.1 dex
127.0.0.1 minio
127.0.0.1 postgres
127.0.0.1 mysql
127.0.0.1 azurite

This approach is doesn't rely on echo version
https://www.gnu.org/software/bash/manual/html_node/ANSI_002dC-Quoting.html

@terrytangyuan terrytangyuan enabled auto-merge (squash) July 22, 2022 03:10
@terrytangyuan terrytangyuan merged commit 15fdf49 into argoproj:master Jul 22, 2022
@sarabala1979 sarabala1979 mentioned this pull request Nov 8, 2022
Closed
reddymh pushed a commit to reddymh/argo-workflows that referenced this pull request Jan 2, 2023
@tczhao
fix: line return in devcontainer host file (argoproj#9204)
0ed97d7 
fix: line return in host file devcontainer

Signed-off-by: Tianchu Zhao <[email protected]>
Signed-off-by: Reddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tczhao @terrytangyuan