Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused argument which is triggering in lint (needed for PRs to pass CI) #9186

Merged
merged 5 commits into from
Jul 20, 2022
Merged

fix: remove unused argument which is triggering in lint (needed for PRs to pass CI) #9186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0edaac6
fix: remove unused argument which was triggering in lint
juliev0 Jul 20, 2022
127155e
fix: references calling method
juliev0 Jul 20, 2022
2e00884
fix: empty commit
juliev0 Jul 20, 2022
f5339e7
fix: empty commit
juliev0 Jul 20, 2022
e1ed828
fix: empty commit
juliev0 Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions workflow/controller/exec_control.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package controller

import (
"context"
"fmt"
"sync"
"time"
Expand All @@ -15,7 +14,7 @@ import (

// applyExecutionControl will ensure a pod's execution control annotation is up-to-date
// kills any pending and running pods when workflow has reached it's deadline
func (woc *wfOperationCtx) applyExecutionControl(ctx context.Context, pod *apiv1.Pod, wfNodesLock *sync.RWMutex) {
func (woc *wfOperationCtx) applyExecutionControl(pod *apiv1.Pod, wfNodesLock *sync.RWMutex) {
if pod == nil {
return
}
Expand Down
2 changes: 1 addition & 1 deletion workflow/controller/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ func (woc *wfOperationCtx) podReconciliation(ctx context.Context) error {
go func(pod *apiv1.Pod) {
defer wg.Done()
performAssessment(pod)
woc.applyExecutionControl(ctx, pod, wfNodesLock)
woc.applyExecutionControl(pod, wfNodesLock)
<-parallelPodNum
}(pod)
}
Expand Down