Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Remove dataflow pipelines from codebase #9071

Merged
merged 3 commits into from
Jun 28, 2022
Merged

chore!: Remove dataflow pipelines from codebase #9071

merged 3 commits into from
Jun 28, 2022

Conversation

terrytangyuan
Copy link
Member

Closes #8998.

@terrytangyuan terrytangyuan marked this pull request as ready for review June 28, 2022 18:20
@alexec alexec changed the title chore: Remove dataflow pipelines from codebase chore!: Remove dataflow pipelines from codebase Jun 28, 2022
@alexec
Copy link
Contributor

alexec commented Jun 28, 2022

(a) Fix lint.
(b) I'm not sure if this is is breaking change or not. Dataflow never went to v1.0. Either way, it should probably be mentioned in the upgrading guide.

@terrytangyuan
chore: fix lint and docs
c73abb4 
Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan
Copy link
Member Author

(a) Fix lint. (b) I'm not sure if this is is breaking change or not. Dataflow never went to v1.0. Either way, it should probably be mentioned in the upgrading guide.

Good point. Updated the docs.

@terrytangyuan terrytangyuan enabled auto-merge (squash) June 28, 2022 20:28
@terrytangyuan terrytangyuan merged commit 146e38a into argoproj:master Jun 28, 2022
@terrytangyuan terrytangyuan deleted the rm-dataflow branch June 28, 2022 23:25
LoricAndre pushed a commit to padoa/argo-workflows that referenced this pull request Aug 1, 2022
@terrytangyuan
chore!: Remove dataflow pipelines from codebase (argoproj#9071)
ef6ce55 
* chore: Remove dataflow pipelines from codebase

Signed-off-by: Yuan Tang <[email protected]>

* chore: Remove autogenerated files

Signed-off-by: Yuan Tang <[email protected]>

* chore: fix lint and docs

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Loric ANDRE <[email protected]>
@louisnow
Copy link

louisnow commented Sep 13, 2022 •
edited
Loading

@alexec @terrytangyuan
We currently use argo dataflow pipelines and rely on it being present and usable within argo.
Does this change mean we can't use argo dataflow pipelines with Argo 3.4+ ?

@louisnow louisnow mentioned this pull request Sep 13, 2022
Closed
reddymh pushed a commit to reddymh/argo-workflows that referenced this pull request Jan 2, 2023
@terrytangyuan
chore!: Remove dataflow pipelines from codebase (argoproj#9071)
de63bfa 
* chore: Remove dataflow pipelines from codebase

Signed-off-by: Yuan Tang <[email protected]>

* chore: Remove autogenerated files

Signed-off-by: Yuan Tang <[email protected]>

* chore: fix lint and docs

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Reddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove argo-dataflow pipelines component from the UI
3 participants
@terrytangyuan @alexec @louisnow