Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve docs #8562

Merged
merged 18 commits into from
May 2, 2022
Merged

docs: Improve docs #8562

merged 18 commits into from
May 2, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 1, 2022

Signed-off-by: Alex Collins [email protected]

As a reviewer, I don't expect you to open and examine every single file because there are too many. Instead I only expect provide high-level feedback:

(a) Are you happy with the problems and solution below? What should be done different?
(b) How does the site look to you? What would you change?


image

Comments section:

image

Problem

Engineers are submitting PRs that have not been tested, listed, or had code generation run. This wastes both theirs and the reviewers time resolving, and delaying the PR merge.

Solution

Install a Git pre-commithook that complain if make pre-commit -B and make test have not been run in the last 15m.

Problem

Users often submit PRs that break the docs. This is because they are not checked by CI, and not easy to test locally. These breakages escape into master. Commonly this results in missing docs, or docs that look wrong. These typically need to be fixed by a maintainer.

Solution

Build the docs on CI so (a) the build fails if the docs are broken and the PR cannot be merged (b) the PR reviewer can check them prior to merge.

This includes:

  • Spell check
  • Broken link check
  • Lint

Problem

Users are struggling to get started, and generally dislike the docs.

Documentation is not much user friendly. Am trying to use workflow plugin feature from yesterday. But the examples provided is not giving me any solid direction.

The documentation is difficult to find things in, and it is a lot of trial and error. The linter needs to be better when using templateRef and not require me to first apply the templates to k8s and then realise something is wrong

Unfortunately the current documentation makes on boarding difficult, the examples are good but not flexible enough. Workflow definitions need to be refactored between different execution mode and requires understanding implementation details including how it'll leverage Kubernetes primitives. To create an efficient DAG based workflow with Emissary executor is not trivial while the error messages are rarely useful

Improvement in the documentation and specifically an always up-to-date API documentation would be great :)

Documentation/blog posts with real examples, applications, best practices. Documentation generally, it's good but I've found some rough spots. My team would love a better Pythonic client for people who aren't k8s nerds -- we just started playing with hera but they're also eyeballing Prefect.

Enhance SSO documentation, add more examples for RBAC rules, clarify where ServiceAccounts and RoleBindings need to be created, etc.

The documentation is spartan. Examples would be find.

documentation and samples on Events and Workflow interactions

Better documentation with full CI/CD flow examples

... Better documentation of how to get up and running with common scenarios. Better templates out-of-the box for common tasks like building kaniko images, gradle builds etc.. with more realistic examples (not just a bunch of whalesay examples -- but rather real-life uses). Documentation more oriented to what the user will need to do rather than just concepts. Even the catakoda tutorials are just a bunch of whalesay...there's a big gap between that and actually using it for more practical things...

Documentation looks bad and outdated.

Solution

  • Include the "docs by example". This was missing.
  • Restructured and re-ordered the navigation.
  • Re-write some parts.
  • Removed duplicate or out-of-date information.
  • Updated the theme.
  • Add comments section to get more feedback.

ℹ️ This PR is pushed to origin rather than a fork because Github Actions will not run changed workflows on forks.

@@ -4,14 +4,16 @@ on:
push:
branches:
- master
pull_request:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run on PRs

@@ -140,12 +140,6 @@ define protoc

endef

.PHONY: build
Copy link
Contributor Author

@alexec alexec May 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defunct targets that should never be run

Makefile Outdated Show resolved Hide resolved
@@ -9,7 +9,7 @@ function check-used {
var="${x%\`}";
var="${var#\`}";
if ! grep -qR --exclude="*_test.go" "$var" ./cmd/workflow-controller ./workflow ./persist ./util ./server ; then
echo "Documented variable $var in docs/environment-variables.md is not used anywhere";
echo "Documented variable $var in docs/environment-variables.md is not used anywhere" >&2;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearer success/failure warnings

alexec added 5 commits May 1, 2022 11:23
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title build: Improve docs CI and build checks docs: Improve docs CI checks, improve docs May 1, 2022
alexec added 5 commits May 1, 2022 17:51
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@@ -454,15 +440,6 @@ dist/argosay:
mkdir -p dist
cp test/e2e/images/argosay/v2/argosay dist/

.PHONY: pull-images
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defunct

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title docs: Improve docs CI checks, improve docs docs: Improve docs May 2, 2022
alexec added 3 commits May 1, 2022 20:08
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review May 2, 2022 04:15
alexec added 2 commits May 1, 2022 21:47
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec enabled auto-merge (squash) May 2, 2022 19:07
@alexec alexec merged commit c2f4506 into master May 2, 2022
@alexec alexec deleted the ci-docs branch May 2, 2022 20:59
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants