-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: submodule cloning via git. Fixes #7469 #8225
Conversation
I've created fork here: https://github.com/argoproj-labs/go-git Can you create a PR for your changes pls? |
created it |
I can also update this PR to use the argo fork. |
Signed-off-by: Hunter-Thompson <[email protected]>
done |
Signed-off-by: Hunter-Thompson <[email protected]>
Not sure why the tests are failing. |
Signed-off-by: Hunter-Thompson <[email protected]>
* fix: submodule cloning via git. Fixes #7469 Signed-off-by: Hunter-Thompson <[email protected]> * chore: add smallcase to USERS.md Signed-off-by: Hunter-Thompson <[email protected]> * chore: move into require block Signed-off-by: Hunter-Thompson <[email protected]>
Signed-off-by: Hunter-Thompson [email protected]
Fixes #7469
The original PR on go-git (go-git/go-git#464) has not been merged since more than a month, with no reply from the maintainers. I think this bug is very big, being unable to clone sub modules makes workflows impossible.
I suggest using a fork that we(smallcase) maintain until that PR is merged.
smallcase/go-git#2