Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submodule cloning via git. Fixes #7469 #8225

Merged
merged 4 commits into from
Mar 24, 2022
Merged

fix: submodule cloning via git. Fixes #7469 #8225

merged 4 commits into from
Mar 24, 2022

Conversation

Hunter-Thompson
Copy link
Contributor

@Hunter-Thompson Hunter-Thompson commented Mar 23, 2022

Signed-off-by: Hunter-Thompson [email protected]

Fixes #7469

The original PR on go-git (go-git/go-git#464) has not been merged since more than a month, with no reply from the maintainers. I think this bug is very big, being unable to clone sub modules makes workflows impossible.

I suggest using a fork that we(smallcase) maintain until that PR is merged.

smallcase/go-git#2

@Hunter-Thompson Hunter-Thompson changed the title fix: submodule cloning via git. Fixes #979 fix: submodule cloning via git. Fixes #7469 Mar 23, 2022
go.mod Outdated Show resolved Hide resolved
@alexec
Copy link
Contributor

alexec commented Mar 24, 2022

I've created fork here:

https://github.com/argoproj-labs/go-git

Can you create a PR for your changes pls?

@Hunter-Thompson
Copy link
Contributor Author

I've created fork here:

https://github.com/argoproj-labs/go-git

Can you create a PR for your changes pls?

created it

argoproj-labs/go-git#1

@Hunter-Thompson
Copy link
Contributor Author

I've created fork here:

https://github.com/argoproj-labs/go-git

Can you create a PR for your changes pls?

I can also update this PR to use the argo fork.

@Hunter-Thompson Hunter-Thompson marked this pull request as draft March 24, 2022 17:38
@Hunter-Thompson Hunter-Thompson marked this pull request as ready for review March 24, 2022 18:04
@Hunter-Thompson
Copy link
Contributor Author

I've created fork here:
https://github.com/argoproj-labs/go-git
Can you create a PR for your changes pls?

I can also update this PR to use the argo fork.

done

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Hunter-Thompson <[email protected]>
@Hunter-Thompson
Copy link
Contributor Author

Not sure why the tests are failing.

Signed-off-by: Hunter-Thompson <[email protected]>
@alexec alexec merged commit 1d373c4 into argoproj:master Mar 24, 2022
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
85 tasks
sarabala1979 pushed a commit that referenced this pull request Apr 18, 2022
* fix: submodule cloning via git. Fixes #7469

Signed-off-by: Hunter-Thompson <[email protected]>

* chore: add smallcase to USERS.md

Signed-off-by: Hunter-Thompson <[email protected]>

* chore: move into require block

Signed-off-by: Hunter-Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clone repository with submodule url [email protected]
2 participants