Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed deprecated kubelet executor. Fixes #7803 #8215

Merged
merged 8 commits into from
Mar 27, 2022
Merged

chore: removed deprecated kubelet executor. Fixes #7803 #8215

merged 8 commits into from
Mar 27, 2022

Conversation

rohankmr414
Copy link
Member

Signed-off-by: Rohan Kumar [email protected]

Fixes #7803

@alexec
Copy link
Contributor

alexec commented Mar 22, 2022

You've some linting errors.

@blkperl
Copy link
Contributor

blkperl commented Mar 25, 2022 •
edited
Loading

Hi @rohankmr414,

Thanks for the PR, I found a few more things to remove.

  • .github/workflows/ci-build.yaml needs to have kubelet removed
  • workflow/validate/validate.go has a reference to the kubelet executor in a comment for ContainerRuntimeExecutor
  • There are some quickstarts for kubelet in manifests/quick-start/base/executor/kubelet
  • KubeletPort and KubeletInsecure are configs only needed by the kubelet executor and can be removed from the config/code/docs (config/config.go & workflow/common/common.go and other places)

blkperl
blkperl reviewed Mar 25, 2022
View reviewed changes
test/e2e/fixtures/needs.go
Docker = Executor("docker")
Emissary = Executor("emissary")
Kubelet = Executor("kubelet")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more

test/e2e/argo_server_test.go:           s.Need(fixtures.None(fixtures.Kubelet))
test/e2e/artifacts_test.go:     s.Need(fixtures.None(fixtures.Docker, fixtures.Kubelet))

@rohankmr414
Copy link
Member Author

@blkperl Thank you for pointing out the errors. I have made the necessary changes. Can you please review it?

@terrytangyuan terrytangyuan self-assigned this Mar 25, 2022
alexec
alexec previously requested changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave Kubernetes executor role example? It’s docs.

@rohankmr414 rohankmr414 force-pushed the kubelet branch 2 times, most recently from 18235f8 to 5a8f321 Compare March 27, 2022 04:02
@rohankmr414
fix: cleanup
7fa0357 
Signed-off-by: Rohan Kumar <[email protected]>
@rohankmr414
fix: removed unused vars
54fc7eb 
Signed-off-by: Rohan Kumar <[email protected]>
@rohankmr414 rohankmr414 requested a review from alexec March 27, 2022 05:24
terrytangyuan
terrytangyuan approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrytangyuan terrytangyuan enabled auto-merge (squash) March 27, 2022 18:24
@terrytangyuan terrytangyuan merged commit 8dbd45c into argoproj:master Mar 27, 2022
@rohankmr414 rohankmr414 deleted the kubelet branch March 27, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blkperl blkperl Awaiting requested review from blkperl

@alexec alexec Awaiting requested review from alexec

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@alexec alexec

@terrytangyuan terrytangyuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove kubelet executor
4 participants
@rohankmr414 @alexec @blkperl @terrytangyuan