Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove docker executor #8212

Merged
merged 7 commits into from
Mar 26, 2022
Merged

Conversation

terrytangyuan
Copy link
Member

Fixes #7795.

Signed-off-by: Yuan Tang [email protected]

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
@blkperl
Copy link
Contributor

blkperl commented Mar 25, 2022

@terrytangyuan There are more references to ContainerRuntimeExecutorDocker in multiple files. Specifically, workflow/controller/workflowpod.go has a lot of code related to the docker socket that can be removed

Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Mar 25, 2022

Where is the remaining docker socket code? I think I've removed them already.

@alexec
Copy link
Contributor

alexec commented Mar 25, 2022

Search for docker.sock?

@terrytangyuan
Copy link
Member Author

Done. Let me know if I missed anything else.

@rohankmr414
Copy link
Member

There are some quickstarts for docker executor in manifests/quick-start/base/executor.

@alexec alexec enabled auto-merge (squash) March 26, 2022 19:06
@alexec alexec merged commit 2dd3749 into argoproj:master Mar 26, 2022
@terrytangyuan terrytangyuan deleted the rm-docker branch March 26, 2022 19:31
@terrytangyuan terrytangyuan restored the rm-docker branch May 18, 2022 20:13
@terrytangyuan terrytangyuan deleted the rm-docker branch May 27, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the deprecated docker executor
4 participants