Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly order emissary combined output. Fixes #8159 #8175

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 17, 2022

Signed-off-by: Alex Collins [email protected]

Fixes #8159

@alexec alexec changed the title fix: Correctly order emissary combined output. Fixes #8168 fix: Correctly order emissary combined output. Fixes #8159 Mar 17, 2022
@alexec alexec marked this pull request as ready for review March 17, 2022 17:02
err := run(x, []string{"echo", "hello", "/dev/stderr"})
assert.NoError(t, err)
data, err := ioutil.ReadFile(varRunArgo + "/ctr/main/stderr")
data, err := ioutil.ReadFile(varRunArgo + "/ctr/main/combined")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps testing more complex output here and make sure the order is correct

@alexec alexec merged commit e7008ea into argoproj:master Mar 17, 2022
@alexec alexec deleted the comb branch March 17, 2022 18:34
@sarabala1979 sarabala1979 mentioned this pull request Mar 18, 2022
12 tasks
sarabala1979 pushed a commit that referenced this pull request Mar 18, 2022
* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request Mar 23, 2022
…rgoproj#8175)

* fix: Correctly order emissary combined output. Fixes argoproj#8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes argoproj#8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes argoproj#8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes argoproj#8168

Signed-off-by: Alex Collins <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
85 tasks
sarabala1979 pushed a commit that referenced this pull request Apr 18, 2022
* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
sarabala1979 pushed a commit that referenced this pull request Apr 18, 2022
* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>

* fix: Correctly order emissary combined output. Fixes #8168

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs from stdout/err is not in order
2 participants