fix(plugins): UX improvements #8122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Seidel <[email protected]>
alexec
reviewed
Mar 10, 2022
workflow/util/plugins/configmap.go
Outdated
| @@ -31,6 +31,7 @@ func ToConfigMap(p *spec.Plugin) (*apiv1.ConfigMap, error) { | |||
| Labels: map[string]string{ | |||
| common.LabelKeyConfigMapType: p.Kind, | |||
| }, | |||
| Namespace: p.ObjectMeta.Namespace, | |||
There was a problem hiding this comment.
minor - simplify to p.Namespace,
Signed-off-by: Felix Seidel <[email protected]>
|
test? |
sarabala1979
approved these changes
Mar 10, 2022
alexec
pushed a commit
that referenced
this pull request
Mar 18, 2022
* fix(plugins): set Content-Type request header Signed-off-by: Felix Seidel <[email protected]> * fix(plugins): keep namespace from plugin manifest Signed-off-by: Felix Seidel <[email protected]>
sarabala1979
pushed a commit
that referenced
this pull request
Mar 18, 2022
* fix(plugins): set Content-Type request header Signed-off-by: Felix Seidel <[email protected]> * fix(plugins): keep namespace from plugin manifest Signed-off-by: Felix Seidel <[email protected]>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
Mar 23, 2022
* fix(plugins): set Content-Type request header Signed-off-by: Felix Seidel <[email protected]> * fix(plugins): keep namespace from plugin manifest Signed-off-by: Felix Seidel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Content-Typeheader is added totemplate.executeRPC calls → apart from technical correctness this makes it easier to use because many frameworks rely on this header for JSON parsing✅ Has an integration test in test/e2e/executor_plugins_test.go
argo executor-plugin build .copies themetadata/namespacefrom the plugin manifest to the ConfigMap✅ Tested on my local machine