fix(executor): Retry kubectl on internal transient error #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(executor): Retry kubectl on internal transient error Signed-off-by: wujayway <[email protected]>
simster7
approved these changes
Mar 7, 2022
Comment on lines
+81
to
+87
| func generateErrorString(err error) string { | ||
| errorString := err.Error() | ||
| if exitErr, ok := err.(*exec.ExitError); ok { | ||
| errorString = fmt.Sprintf("%s %s", errorString, exitErr.Stderr) | ||
| } | ||
| return errorString | ||
| } |
add ut Signed-off-by: wujayway <[email protected]>
add ut Signed-off-by: wujayway <[email protected]>
terrytangyuan
approved these changes
Mar 8, 2022
alexec
pushed a commit
that referenced
this pull request
Mar 18, 2022
* fix(executor): Retry kubectl on internal transient error fix(executor): Retry kubectl on internal transient error Signed-off-by: wujayway <[email protected]> * add ut add ut Signed-off-by: wujayway <[email protected]> * add ut add ut Signed-off-by: wujayway <[email protected]>
sarabala1979
pushed a commit
that referenced
this pull request
Mar 18, 2022
* fix(executor): Retry kubectl on internal transient error fix(executor): Retry kubectl on internal transient error Signed-off-by: wujayway <[email protected]> * add ut add ut Signed-off-by: wujayway <[email protected]> * add ut add ut Signed-off-by: wujayway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(executor): Retry kubectl on internal transient error
Signed-off-by: wujayway [email protected]
Fixes fix(executor): Retry kubectl on internal transient error
This PR(#6472, #6467) only fix retry kubectl on k8s api error.
We also need to retry kubectl on internal transient error.