Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update new version modal for v3.3. Fixes #7639 #7707

Merged
merged 3 commits into from
Feb 14, 2022
Merged

feat: Update new version modal for v3.3. Fixes #7639 #7707

merged 3 commits into from
Feb 14, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 31, 2022

Signed-off-by: Alex Collins [email protected]
Fixes #7639

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked docs do not exist and are not ready yet.

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review February 14, 2022 23:35
@alexec alexec enabled auto-merge (squash) February 14, 2022 23:35
@alexec
Copy link
Contributor Author

alexec commented Feb 14, 2022

2 weeks old. Not going to wait for docs anymore.

@alexec alexec merged commit 11890b4 into master Feb 14, 2022
@alexec alexec deleted the modal branch February 14, 2022 23:52
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update new-version-modal.tsx with v3.3 content
2 participants