fix: Fix inconsistent ordering of workflows with the list command.

[dinever]

Fixes #7581

Hi, this PR fixes an issue where argo list -o name has inconsistent display order than argo list. The root cause is that we sort workflows based on CreationTimestamp and FinishedAt:

argo-workflows/pkg/apis/workflow/v1alpha1/workflow_types.go

Lines 130 to 145 in f1fe3be

	func (w Workflows) Less(i, j int) bool {
	iStart := w[i].ObjectMeta.CreationTimestamp
	iFinish := w[i].Status.FinishedAt
	jStart := w[j].ObjectMeta.CreationTimestamp
	jFinish := w[j].Status.FinishedAt
	if iFinish.IsZero() && jFinish.IsZero() {
	return !iStart.Before(&jStart)
	}
	if iFinish.IsZero() && !jFinish.IsZero() {
	return true
	}
	if !iFinish.IsZero() && jFinish.IsZero() {
	return false
	}
	return jFinish.Before(&iFinish)
	}

So we need to make sure these two fields are included in the name-only field selectors as well, in order to have a consistent sort.

Before

Workflows have inconsistent display order with / without -o name

After

Workflows have consistent display order now

Thanks!

Signed-off-by: Peixuan Ding [email protected]

[alexec]

Good work!